Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

seal PyAddToModule #4606

Merged
merged 3 commits into from
Oct 9, 2024
Merged

seal PyAddToModule #4606

merged 3 commits into from
Oct 9, 2024

Conversation

Cheukting
Copy link
Contributor

Related to issue #3908 and in replace of PR #4368

Further PRs can be made to complete #3908

@Cheukting Cheukting mentioned this pull request Oct 9, 2024
Closed
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Oct 9, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #4606 will improve performances by 91.39%

Comparing Cheukting:sealed2 (27b1953) with main (4cbf6e0)

Summary

⚡ 2 improvements
✅ 81 untouched benchmarks

Benchmarks breakdown

Benchmark main Cheukting:sealed2 Change
⚡ call 1,188 µs 620.7 µs +91.39%
⚡ call_method 2 ms 1.3 ms +55.05%

Icxolu
Icxolu approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@Icxolu Icxolu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM 💯

@Icxolu Icxolu added this pull request to the merge queue Oct 9, 2024
Merged via the queue into PyO3:main with commit 96da64b Oct 9, 2024
43 checks passed
@davidhewitt
Copy link
Member

Thanks @Cheukting, and sorry for my part in #4368 stalling out. There has been a lot of spinning plates my end 😩

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Icxolu Icxolu Icxolu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Cheukting @davidhewitt @Icxolu