Add __next__ return #997
Merged
Add __next__ return #997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhewitt
force-pushed
the
pyproto-next-return
branch
from
d8cb1e6 to
e90a270
Compare
kngwyu
requested changes
Jun 23, 2020
|
Thank you! Looks good but I want to make general |
davidhewitt
force-pushed
the
pyproto-next-return
branch
2 times, most recently
from
b31894f to
a9827a4
Compare
|
Thanks, I like that design. I've pushed that to the branch and added a small sample to the guide. |
kngwyu
reviewed
Jun 23, 2020
kngwyu
reviewed
Jun 23, 2020
kngwyu
approved these changes
Jun 23, 2020
davidhewitt
force-pushed
the
pyproto-next-return
branch
2 times, most recently
from
df34963 to
c67e94d
Compare
|
Good feedback, thanks - I've shortened the doc and moved most of it to |
davidhewitt
force-pushed
the
pyproto-next-return
branch
from
c67e94d to
e1105f4
Compare
|
Looks rustfmt complains... |
kngwyu
reviewed
Jun 23, 2020
davidhewitt
force-pushed
the
pyproto-next-return
branch
from
e1105f4 to
9f9137c
Compare
|
🤦 pushed fixed formatting. |
|
Thanks! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on #996 by enabling ability to
returna value in theStopIterationexception.If you like this approach I'll write some docs in the guide before we merge this PR.