Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Simplify HierarchicalTimer implementation #97

Open
jsiirola opened this issue Apr 6, 2020 · 0 comments
Open

Simplify HierarchicalTimer implementation #97

jsiirola opened this issue Apr 6, 2020 · 0 comments

Comments

@jsiirola
Copy link
Contributor

jsiirola commented Apr 6, 2020

This issue documents possible TODOs for the HierarchicalTimer implementation that could be "nice to haves", but shouldn't hold up PR #96:

  • Remove redundancy in the string representation. Significant logic (and embedded constants) are duplicated between HierarchicalTimer.__str__() and _HierarchicalHelper.to_str(). It is possibel that we might be able to accomplish this by refactoring the logic to only have a single class.
  • Switch __str__ indententation to be a consistent (4?) spaces. This will allow for longer identifiers without causing the table to become too wide to easily display.
  • Add a check to prevent users from including separators ('.') in identifier names
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant