Skip to content

Update utils.deprecated to use PEP 702 #1917

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Open
BobDotCom opened this issue Feb 10, 2023 · 1 comment · May be fixed by #2655
Open

Update utils.deprecated to use PEP 702 #1917

BobDotCom opened this issue Feb 10, 2023 · 1 comment · May be fixed by #2655
Labels
feature request New feature request on hold status: planned Planned in the future

Comments

@BobDotCom
Copy link
Member

Summary

PEP 702 introduces a new typing.deprecated decorator, we should use it.

What is the feature request for?

The core library

The Problem

A more standard way of declaring deprecations

The Ideal Solution

Internally call typing.deprecated inside of utils.deprecated, instead of manually creating a warning (or maybe both?)

The Current Solution

No response

Additional Context

Although @typing.deprecated is slated for python 3.12, it was added to typing-extensions in python/typing_extensions#105, and we should use this for backwards support.
@BobDotCom BobDotCom added the feature request New feature request label Feb 10, 2023
@Lulalaby Lulalaby added this to the v2.5 milestone Feb 10, 2023
@BobDotCom BobDotCom removed this from the v2.5 milestone Apr 26, 2023
@BobDotCom BobDotCom added the status: planned Planned in the future label Apr 26, 2023
@Dorukyum Dorukyum removed the on hold label Dec 2, 2023
@Paillat-dev
Copy link
Contributor

Can work on this if someone tells me what is the preferred way of handling it.

@Paillat-dev Paillat-dev linked a pull request Nov 27, 2024 that will close this issue
Open
9 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
feature request New feature request on hold status: planned Planned in the future
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: ♻️ Use typing_extensions.deprecated instead of own implementation Paillat-dev/pycord
4 participants
@Lulalaby @Dorukyum @BobDotCom @Paillat-dev