Add from complex matrix function #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtreinish
force-pushed
the
complex-adj-matrix
branch
from
bd7e12b to
762576d
Compare
There was a problem hiding this comment.
Update: I confirmed it is not possible, we have to stick with the current implementation
I agree that we should make #411 possible, but I would implement this differently.
If we make a generic function that can take arbitrary Python, it would have the same effect and avoid PyO3/pyo3#1798. We could also support optional callables to make it even more flexible e.g:
# without optional arguments
retworkx.PyGraph.from_custom_adjacency_matrix(adjacency_matrix) # complex numbers
# with optional arguments
retworkx.PyGraph.from_custom_adjacency_matrix(
adjacency_matrix,
weight_fn=lambda x: x.imag,
null_value=0.0
) # example to do arbitrary conversions etcThis commit adds a new constructor method from_complex_adjacency_matrix that will build a new graph from an adjacency matrix with complex elements. Fixes Qiskit#411
This commit updates the implementation of the from_adjacency_matrix() functions to have a shared generic private function to be shared across the per type variants. To accomplish this the IsNan trait from rust nightly is copied into retworkx (so we can build with stable rust). If in the future if an int type variant is added we'll need to implement this trait for the int type (and just return false). Co-authored-by: georgios-ts <45130028+georgios-ts@users.noreply.github.com>
mtreinish
force-pushed
the
complex-adj-matrix
branch
from
857b009 to
c446083
Compare
Pull Request Test Coverage Report for Build 1221392238
💛 - Coveralls |
mtreinish
changed the title
georgios-ts
approved these changes
Sep 7, 2021
Co-authored-by: georgios-ts <45130028+georgios-ts@users.noreply.github.com>
georgios-ts
reviewed
Sep 10, 2021
Co-authored-by: georgios-ts <45130028+georgios-ts@users.noreply.github.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new constructor method from_complex_adjacency_matrix
that will build a new graph from an adjacency matrix with complex
elements.
Fixes #411
TODO: