Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix issue where color-string with incorrectly return a color for properties on Object's prototype like "constructor". #45

Closed
wants to merge 1 commit into from
Closed

Fix issue where color-string with incorrectly return a color for properties on Object's prototype like "constructor". #45

wants to merge 1 commit into from

Conversation

tolmasky
Copy link
Contributor

Closes #44.

Reviewed by @tolmasky.

@tolmasky
Fix issue where color-string with incorrectly return a color for prop…
ab34443 
…erties on Object's prototype like "constructor".

Closes Qix-#44.

Reviewed by @tolmasky.
@Qix-
Copy link
Owner

Qix- commented Nov 26, 2021

Thanks :) Landed ultimately in 20e55f3 after I added a failing test in b7c685f. Released as 1.7.2.

@Qix- Qix- closed this Nov 26, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

color-string incorrectly believes prototype properties are colors
2 participants
@tolmasky @Qix-