Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

add PermMatrixCSC #78

Merged
merged 13 commits into from
Apr 17, 2024
Merged

add PermMatrixCSC #78

merged 13 commits into from
Apr 17, 2024

Conversation

GiggleLiu
Copy link
Member

@GiggleLiu GiggleLiu commented Feb 25, 2024

We should gradually switch to the column majored permutation matrix for better performance.

NOTE: this is a non-breaking feature.

Copy link

codecov bot commented Feb 25, 2024

Codecov Report

Attention: Patch coverage is 88.61386% with 23 lines in your changes are missing coverage. Please review.

Project coverage is 91.38%. Comparing base (77ff1ed) to head (f9b46fc).
Report is 1 commits behind head on master.

❗ Current head f9b46fc differs from pull request most recent head 09f60d7. Consider uploading reports for the commit 09f60d7 to get more accurate results

Files Patch % Lines
src/conversions.jl 78.78% 7 Missing ⚠️
src/linalg.jl 84.09% 7 Missing ⚠️
src/PermMatrix.jl 93.47% 3 Missing ⚠️
src/arraymath.jl 85.71% 3 Missing ⚠️
src/promotions.jl 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #78      +/-   ##
==========================================
+ Coverage   88.85%   91.38%   +2.52%     
==========================================
  Files          14       14              
  Lines         754      789      +35     
==========================================
+ Hits          670      721      +51     
+ Misses         84       68      -16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GiggleLiu GiggleLiu requested a review from Roger-luo February 26, 2024 03:16
@Roger-luo
Copy link
Member

If it's non-breaking we should only bump patch version according to the convention. Don't bump the version inside PR.

src/PermMatrix.jl Show resolved Hide resolved
src/PermMatrix.jl Outdated Show resolved Hide resolved
Project.toml Outdated Show resolved Hide resolved
@GiggleLiu GiggleLiu merged commit d55a7d7 into master Apr 17, 2024
2 checks passed
@GiggleLiu GiggleLiu deleted the jg/permcsc branch April 17, 2024 01:59
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants