Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Request: minified version #6

Closed
Xpedite opened this issue Mar 31, 2017 · 5 comments
Closed

Request: minified version #6

Xpedite opened this issue Mar 31, 2017 · 5 comments

Comments

@Xpedite
Copy link

Xpedite commented Mar 31, 2017

I love the SDK 👍 but can we also get a minified js file in the dist folder please ?

Keep up the good work !

@evias
Copy link
Contributor

evias commented Mar 31, 2017

+1, what about this @QuantumMechanics : https://github.com/babel/babili with this one we might be able to integrate the minifying right into the package.json. Using gulp would also work (see NanoWallet) but needs more configuration i'm sure.

Following is a working example of babili integration (i just tested on nem-sdk package, out of 2.4 Mb dist/nem-sdk.js, it produces a 1.3 Mb dist/nem-sdk.min.js) - i'm still looking for other implementations and maybe QM's opinion but here is the quick fix that would work with babili:

image

Other suggestions appreciated of course! :)

@QuantumMechanics
Copy link
Owner

QuantumMechanics commented Apr 3, 2017

Hi,

Hmm I am a bit worried about this issue: babel/minify#485

Using uglifyJS directly on the browserified file should be good for now I guess

@evias
Copy link
Contributor

evias commented Apr 7, 2017

uglify-js dependency added in #7 and versioning process updated to, @QuantumMechanics you would only need to npm version 1.0.1-RC4 && npm publish after merge

@Xpedite : maybe before QM merges the PR, you want to test the minified file? If you wish you can fork my fork and you will be able to run "npm run minify" to have the minified JS: https://github.com/evias/NEM-sdk

@Xpedite
Copy link
Author

Xpedite commented Apr 25, 2017

Sorry guys, I lost track of this.
I guess it can be closed now since #7 has been merged.

@evias
Copy link
Contributor

evias commented Apr 25, 2017

yep you can now run npm minify 👍

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants