Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Automatically renamed members can't be remapped #253

Open
rubybrowncoat opened this issue Jan 19, 2025 · 5 comments
Open

Automatically renamed members can't be remapped #253

rubybrowncoat opened this issue Jan 19, 2025 · 5 comments
Labels
backend affects the enigma backend bug Something isn't working

Comments

@rubybrowncoat
Copy link

If you activate the Rename Members option

Image

Automatically renamed fields and methods can't be remapped.

Image
@ix0rai ix0rai added bug Something isn't working backend affects the enigma backend labels Jan 19, 2025
@ix0rai
Copy link
Member

ix0rai commented Jan 19, 2025

what's your use case for this option?

@rubybrowncoat
Copy link
Author

Right now I'm just trying to figure out a way to bypass #249 and this looked like a promising way since it renames illegal identifiers (java keywords, extremely long/short, or reserved namespaces, looking at the default IIdentifierRenamer implementation)

@IotaBread
Copy link
Member

might be a vineflower bug, i'll take a look

@IotaBread
Copy link
Member

huh, i cant open any file with the option enabled

@rubybrowncoat
Copy link
Author

huh, i cant open any file with the option enabled

Right, forgot I compiled it with vineflower 1.11.0-SNAPSHOT to not crash with that option.

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
backend affects the enigma backend bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rubybrowncoat @IotaBread @ix0rai