Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

drivers/at: remove at_urc_isr module #20059

Closed
derMihai opened this issue Nov 8, 2023 · 1 comment
Closed

drivers/at: remove at_urc_isr module #20059

derMihai opened this issue Nov 8, 2023 · 1 comment
Assignees

Comments

@derMihai
Copy link
Contributor

derMihai commented Nov 8, 2023

Description

The at_urc_isr module introduced with #14327 comes with a number of bugs. The issues are:

  • improper use of fencing - accesses to at_dev_t::awaiting_response should use the C11 atomics, as there is little preventing an optimizing compiler from moving them around.
  • The URC handling in ISR may catch command responses - as @aaltuntas points out, after an AT command is issued, the ISR handling is enabled and disabled multiple times, allowing it to wrongly intercept responses as URCs

As I am neither interested in this feature, nor able to produce enough test coverage, I am not willing (at least for the moment) to fix it. Therefore, until someone will fix this, I suggest It should either be removed, or marked as experimental and compilation should fail when enabled.

@derMihai
Copy link
Contributor Author

I will close this, as #20423 solves this.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants