Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Clarifying comment in is_corpus func in utils.py #1109

Merged
merged 1 commit into from
Jan 31, 2017
Merged

Clarifying comment in is_corpus func in utils.py #1109

merged 1 commit into from
Jan 31, 2017

Conversation

greninja
Copy link
Contributor

@greninja greninja commented Jan 27, 2017 •
edited by tmylk
Loading

Discussed in #1108 (comment)

@tmylk tmylk merged commit 6555f98 into piskvorky:develop Jan 31, 2017
@tmylk
Copy link
Contributor

tmylk commented Jan 31, 2017

Thanks for the clarification!

@piskvorky
Copy link
Owner

That comment is not coherent:

if obj is a 1D numpy array(scalars) instead of 2-tuples, it resolves to False here

I'd propose if obj is a 1D numpy array instead of a sequence of 2-tuples, doc1 will be a scalar => resolves to False here.

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@greninja @tmylk @piskvorky