Add the 'keep_tokens' parameter to 'filter_extremes' and test it #1210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the optional 'keep_tokens' parameter to the 'filter_extremes' method in dictionary.py. This parameter can contain a list of tokens, which will be kept regardless of the 'no_below' and 'no_above' settings. This can be useful if the research goal is to enforce certain tokens to appear in topics, and still be able to filter all other extremes. If 'keep_tokens' is not given, the functionality of 'filter_extremes' is unchanged. Unit tests are also provided to assert examples of the above.
|
The travis-ci check failed because: I do not know how this can affect my commit, as not providing the optional 'keep_tokens' parameter should not change any functionality in dictionary.py, see the unit tests. How can this commit be included successfully? |
|
@toliwa It's not related to your code changes, just the new release of scipy 0.19 Changing it to |
tmylk
suggested changes
Mar 13, 2017
gensim/corpora/dictionary.py
Outdated
| # add ids of keep_tokens elements to good_ids | ||
| if keep_tokens: | ||
| keep_ids = [self.token2id[v] for v in keep_tokens if v in self.token2id] | ||
| good_ids_copy = (v for v in itervalues(self.token2id) if no_below <= self.dfs.get(v, 0) <= no_above_abs) |
There was a problem hiding this comment.
please keep to a single iteration of token2id by adding a or v in keep_tokens check if keep_tokens is present
|
Please merge in the latest develop to make the tests pass. |
Create good_ids only once as per optimization suggestion, regardless if 'keep_tokens' is provided or not.
tmylk
approved these changes
Mar 13, 2017
|
Thanks for the new feature! |
pranaydeeps
pushed a commit
to pranaydeeps/gensim
that referenced
this pull request
Mar 21, 2017
* Add the 'keep_tokens' parameter to 'filter_extremes' and test it Add the optional 'keep_tokens' parameter to the 'filter_extremes' method in dictionary.py. This parameter can contain a list of tokens, which will be kept regardless of the 'no_below' and 'no_above' settings. This can be useful if the research goal is to enforce certain tokens to appear in topics, and still be able to filter all other extremes. If 'keep_tokens' is not given, the functionality of 'filter_extremes' is unchanged. Unit tests are also provided to assert examples of the above. * Create good_ids only once Create good_ids only once as per optimization suggestion, regardless if 'keep_tokens' is provided or not.
piskvorky
reviewed
Apr 9, 2017
| if no_below <= self.dfs.get(v, 0) <= no_above_abs) | ||
| if keep_tokens: | ||
| keep_ids = [self.token2id[v] for v in keep_tokens if v in self.token2id] | ||
| good_ids = (v for v in itervalues(self.token2id) |
There was a problem hiding this comment.
Code style: no vertical indent in gensim -- please use hanging indent.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the optional 'keep_tokens' parameter to the 'filter_extremes'
method in dictionary.py. This parameter can contain a list of tokens,
which will be kept regardless of the 'no_below' and 'no_above' settings.
This can be useful if the research goal is to enforce certain tokens to
appear in topics, and still be able to filter all other extremes.
If 'keep_tokens' is not given, the functionality of 'filter_extremes' is
unchanged.
Unit tests are also provided to assert examples of the above.