Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

glove2word2vec improvements #1247

Merged
merged 3 commits into from
Mar 30, 2017
Merged

glove2word2vec improvements #1247

merged 3 commits into from
Mar 30, 2017

Conversation

parulsethi
Copy link
Contributor

@parulsethi parulsethi commented Mar 29, 2017 •
edited
Loading

This PR combines the 'file read/write' code for both python 2 and 3, in glove2word2vec conversion.

Also, removed tests from end of the conversion script and added it to the previously added test_glove2word2vec.py

@tmylk
Copy link
Contributor

tmylk commented Mar 29, 2017

Thank you for the improvement.
For better tests please add some non-ascii characters to https://github.com/RaRe-Technologies/gensim/blob/develop/gensim/test/test_data/test_glove.txt

@parulsethi
Copy link
Contributor Author

Sure, added few non-ascii characters in the beginning of file.

@tmylk tmylk merged commit 99151db into piskvorky:develop Mar 30, 2017
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@parulsethi @tmylk