Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove plotly's dendrogram code in notebooks #1571

Merged
merged 2 commits into from
Oct 16, 2017

Conversation

parulsethi
Copy link
Contributor

Removed the modified dendrogram code from visualization notebooks, as plotly/plotly.py#807 has been merged.

@menshikh-iv
Copy link
Contributor

menshikh-iv commented Sep 8, 2017

@parulsethi I don't see new plotly release, it's not released yet (with your addition)?

@parulsethi
Copy link
Contributor Author

Yeah, my addition is in their master branch for now. We can either add a note in the notebook to clone and install plotly directly from github to use the visualization or else wait for the next release.

@menshikh-iv
Copy link
Contributor

menshikh-iv commented Sep 14, 2017

@parulsethi
Pin concrete plotly version in your notebook (for example, cells with pip install plotly==needed_version) + description why you need this version. You should do it after plotly official release and I'll merge this.

@menshikh-iv
Copy link
Contributor

I pinned needed plotly version & re-run notebook, thanks @parulsethi 🌟

@menshikh-iv menshikh-iv merged commit 1c7e72f into piskvorky:develop Oct 16, 2017
horpto pushed a commit to horpto/gensim that referenced this pull request Oct 28, 2017
* remove plotly's dendrogram code in notebooks

* pin plotly, re-run notebooks
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants