Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix doc2vec-lee notebook #1870

Merged
merged 1 commit into from
Feb 5, 2018
Merged

Conversation

numericlee
Copy link
Contributor

Remove .words from lines 613 and 617

Remove .words from lines 613 and 617
@numericlee
Copy link
Contributor Author

Without this change, code gives an error "list has no attribute .words"

@menshikh-iv
Copy link
Contributor

Nice catch @numericlee! I'll merge it after release.

@menshikh-iv
Copy link
Contributor

@numericlee congratz with first PR 👍

@menshikh-iv menshikh-iv changed the title Update doc2vec-lee.ipynb Fix doc2vec-lee notebook Feb 5, 2018
@menshikh-iv menshikh-iv merged commit 1b1f90c into piskvorky:develop Feb 5, 2018
sj29-innovate pushed a commit to sj29-innovate/gensim that referenced this pull request Feb 21, 2018
Remove .words from lines 613 and 617
@piskvorky
Copy link
Owner

piskvorky commented Apr 8, 2018

I don't get it -- wasn't that .words specifically added by @PeterHamilton in #1841?

This PR effectively reverses that one. They can't both be right.

@menshikh-iv
Copy link
Contributor

@piskvorky this fix for the mistake from #1841, train_corpus is list of TaggedDocument (in this case .words needed), but test_corpus is list of list of str, and here, we have no attribute .words.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants