[MRG] Fix FastText word-vectors w/ ngrams/buckets off #2891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gojomo
changed the title
gojomo
changed the title
|
(last commit 8f64b48 doesn't belong here: force-reverting) |
This was referenced Jul 26, 2020
piskvorky
reviewed
Jul 26, 2020
gojomo
changed the title
piskvorky
approved these changes
Jul 27, 2020
|
Low risk, removes flaw, has test, @piskvorky-reviewed - pushing merge button. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In looking at the potential for #2879, I'm finding bugs & suboptimalities in
FastText. This quickie lets FastText work like Word2Vec, when ngrams are disabled - something that should've worked earlier, but seems to have never been tested.