Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Remove gensim.viz submodule #3055

Merged
merged 2 commits into from
Feb 27, 2021
Merged

Remove gensim.viz submodule #3055

merged 2 commits into from
Feb 27, 2021

Conversation

mpenkov
Copy link
Collaborator

@mpenkov mpenkov commented Feb 27, 2021

Partially address #2852

@mpenkov mpenkov requested a review from piskvorky February 27, 2021 14:39
piskvorky
piskvorky reviewed Feb 27, 2021
View reviewed changes
Copy link
Owner

@piskvorky piskvorky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about removing plotly too? Still needed?

@mpenkov
Copy link
Collaborator Author

mpenkov commented Feb 27, 2021

Good point, let's remove it.

@mpenkov
Copy link
Collaborator Author

mpenkov commented Feb 27, 2021

Added to https://github.com/RaRe-Technologies/gensim/wiki/Migrating-from-Gensim-3.x-to-4

@mpenkov mpenkov merged commit 5637303 into develop Feb 27, 2021
@mpenkov mpenkov deleted the rmviz branch February 27, 2021 17:06
@piskvorky piskvorky changed the title rm gensim.viz submodule Remove gensim.viz submodule Mar 21, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@piskvorky piskvorky piskvorky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mpenkov @piskvorky