Record lifecycle events in Gensim models #3060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpenkov
reviewed
Mar 4, 2021
gojomo
reviewed
Mar 4, 2021
piskvorky
changed the title
|
Do we need to document how to use this stuff? Or is this for us gensim developers only? |
|
What documentation are you thinking of? (beyond the docstring I put in there) Yes, I conceive this event log as mostly for us. But that may be just my lack of imagination. What public uses / documentation do you envision? CC @gojomo Perhaps we can ask for this log in ISSUE_TEMPLATE.md. |
|
Yeah, putting this in the issue template would help, because it would save us asking them what they did to the model. That would be sufficient for doco purposes, IMHO. |
|
Okay. Done. |
remove unused import
mpenkov
changed the title
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2863. See the discussion there for motivation.