[MRG] Make WMD normalization optional #3073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gojomo
reviewed
Mar 15, 2021
|
Other than my line-comment highlighting some possibilities around the zero-case threshold & default-return, the core default-but-optional norming looks good! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up from #3067:
This PR introduces an optional
KeyedVectors.wmdistance(norm=True/False)parameter. Users can now choose whether to normalize their embedding vectors in eachwmdistancecall or not.Prior behaviour:
gensim < 4.0: no normalization; user had to normalize all vectors explicitly manually (destructive operation).gensim == 4.0.0beta: normalize dynamically with each call =norm=Truehardwired.gensim > 4.0.0beta(this PR): defaultnorm=True, optionalnorm=False.