Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix various documentation warnings #3077

Merged
merged 5 commits into from
Mar 16, 2021
Merged

fix various documentation warnings #3077

merged 5 commits into from
Mar 16, 2021

Conversation

mpenkov
Copy link
Collaborator

@mpenkov mpenkov commented Mar 16, 2021

I encountered the following while building under Sphinx 3.5.2 on MacOS:

docstring of gensim.corpora._mmreader.MmReader.num_docs:1:duplicate object description of gensim.corpora._mmreader.MmReader.num_docs, other instance in corpora/_mmreader, use :noindex: for one of them

gensim/gensim/utils.py:docstring of gensim.utils.chunkize:9:Inline interpreted text or phrase reference start-string without end-string.

gensim/docs/src/_matutils.rst:document isn't included in any toctree

I encountered the following while building under Sphinx 3.5.2 on MacOS:

docstring of gensim.corpora._mmreader.MmReader.num_docs:1:duplicate object description of gensim.corpora._mmreader.MmReader.num_docs, other instance in corpora/_mmreader, use :noindex: for one of them

gensim/gensim/utils.py:docstring of gensim.utils.chunkize:9:Inline interpreted text or phrase reference start-string without end-string.

gensim/docs/src/_matutils.rst:document isn't included in any toctree
@mpenkov mpenkov requested a review from piskvorky March 16, 2021 01:32
@mpenkov mpenkov mentioned this pull request Mar 16, 2021
7 tasks
@piskvorky
Copy link
Owner

piskvorky commented Mar 16, 2021

I encountered the following while building under Sphinx 3.5.2 on MacOS:

IIRC Ivan couldn't get the docs to run on Sphinx 3 at all:

https://github.com/RaRe-Technologies/gensim/blob/338ef330dea97c90c3180a9b570be9d0c9cef302/setup.py#L303-L306

Does this mean Sphinx 3 works now?

If so, the setup.py (and possibly other places) should be updated too.

@mpenkov
Copy link
Collaborator Author

mpenkov commented Mar 16, 2021

Yeah, I think that comment is out of date.

I'll try removing the pin, but it's possible it will cause a massive rebuild of everything, which isn't what we want.

@mpenkov mpenkov merged commit 2589c5a into develop Mar 16, 2021
@mpenkov mpenkov deleted the docfix branch March 16, 2021 08:32
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants