Parameter name change in HdpModel and dtmmodel to be consistent with LdaModel #755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topcis, topn -> num_topics, num_words to match LdaModel
|
Thanks for the PR! |
This was referenced Jul 2, 2016
Merged
Merged
tmylk
pushed a commit
that referenced
this pull request
Jul 4, 2016
This was referenced Mar 8, 2017
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parameters topics and topn have been changed to num_topics and num_words in the methods show_topics() and print_topics() to be consistent with LdaModel. The calls to those methods have been changed as well in the tests.