Revert "try mock to test."

Rachelint · Rachelint · commit 517159dcf754 · 2024-10-03T15:20:45.000+08:00
This reverts commit 910f621.
diff --git a/datafusion/physical-plan/src/aggregates/row_hash.rs b/datafusion/physical-plan/src/aggregates/row_hash.rs
@@ -1060,9 +1060,11 @@ impl GroupedHashAggregateStream {
     fn switch_to_skip_aggregation(&mut self) -> Result<()> {
         if let Some(probe) = self.skip_aggregation_probe.as_mut() {
             if probe.should_skip() {
-                // let batch = self.emit(EmitTo::All, false)?;
-                let batch = RecordBatch::new_empty(self.schema.clone());
+                dbg!("should skip");
+                let batch = self.emit(EmitTo::All, false)?;
                 self.exec_state = ExecutionState::ProducingOutput(batch);
+            } else {
+                dbg!("should not skip");
             }
         }
 

Original file line number	Diff line number	Diff line change
`@@ -1060,9 +1060,11 @@ impl GroupedHashAggregateStream {`
`1060`	`1060`	`fn switch_to_skip_aggregation(&mut self) -> Result<()> {`
`1061`	`1061`	`if let Some(probe) = self.skip_aggregation_probe.as_mut() {`
`1062`	`1062`	`if probe.should_skip() {`
`1063`		`- // let batch = self.emit(EmitTo::All, false)?;`
`1064`		`- let batch = RecordBatch::new_empty(self.schema.clone());`
	`1063`	`+ dbg!("should skip");`
	`1064`	`+ let batch = self.emit(EmitTo::All, false)?;`
`1065`	`1065`	`self.exec_state = ExecutionState::ProducingOutput(batch);`
	`1066`	`+ } else {`
	`1067`	`+ dbg!("should not skip");`
`1066`	`1068`	`}`
`1067`	`1069`	`}`
`1068`	`1070`