Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

#292 - Allow longer threshold for RSS Sync #428

Merged
merged 2 commits into from
Jan 24, 2017
Merged

#292 - Allow longer threshold for RSS Sync #428

merged 2 commits into from
Jan 24, 2017

Conversation

onedr0p
Copy link
Contributor

@onedr0p onedr0p commented Jan 24, 2017 •
edited by galli-leo
Loading

Update RSS Sync interval default to 60 minutes, and don't allow values below 10 or higher than 720 minutes (12 hours)

Database Migration

NO

Issues Fixed or Closed by this PR

#292

@onedr0p
#292 - Allow longer threshold for RSS Sync
b806f0f 
Update RSS Sync interval default to 60 minutes, and don't allow values below 60 or higher than 720 minutes (12 hours)
@onedr0p onedr0p requested a review from galli-leo January 24, 2017 20:02
galli-leo
galli-leo suggested changes Jan 24, 2017
View reviewed changes
Copy link
Contributor

@galli-leo galli-leo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you shouldn't set the minimum to 60. Changing the default to 60 is a good idea. However, I would still allow users to go lower, i.e. when you don't have API limits to worry about.

@galli-leo galli-leo merged commit 2c56d60 into develop Jan 24, 2017
@onedr0p onedr0p deleted the patch/rss-sync-interval branch January 24, 2017 20:37
@schumi2004
Copy link
Contributor

I'm on latest release 226 but it doesn't allow me to set higher value for rss. It still is 120 in input field and Gui also says Max 120

@schumi2004 schumi2004 mentioned this pull request Jan 25, 2017
Merged
ta264 pushed a commit that referenced this pull request Dec 10, 2019
@Qstick
New: Added optional UrlBase to Nzbget, Sabnzbd, and Subsonic settings (…
9aa40f5 
…#428)

* New: Added optional UrlBase to Nzbget, Sabnzbd, and Subsonic settings

Fixes #386

* fixup! Remove commented code
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 21, 2020
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@galli-leo galli-leo galli-leo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@onedr0p @schumi2004 @galli-leo