Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

add pvalue filter to eQTL_Catalogue.fetch? #9

Open
paul-shannon opened this issue May 9, 2022 · 3 comments
Open

add pvalue filter to eQTL_Catalogue.fetch? #9

paul-shannon opened this issue May 9, 2022 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@paul-shannon
Copy link

Thank you for this fine package.
Using the dev branch, I sometimes query over large (4M) regions for eqtls, encountering errors like this:

eQTL_Catalogue.fetch failed on study GTEx_V8.Brain_Cerebellum
<simpleError in readBin(structure(3L, class = c("curl", "connection"), 
                                         conn_id = <pointer: 0x951>),   raw(0), 32768L): 
transfer closed with 34871729 bytes remaining to read>

I see that the table returned by fetch (in smaller regions, for instance) has pvals up to 1.0.
Perhaps you could add an extra parameter to the fetch function, specifying a maximum pval, thereby allowing us to greatly reduce the size of the table returned?

@bschilder
Copy link
Member

Hi @paul-shannon , thanks for your interest incatalogueR! I'm actually in the process of upgrading all my echoverse packages.
I can definitely add this once I get to catalogueR. I'm almost done upgrading all the subpackages it depends on.

Best,
Brian

@bschilder bschilder added the enhancement New feature or request label May 9, 2022
@paul-shannon
Copy link
Author

@bschilder - great, thank you. Perhaps also a target gene filter option as well?

@bschilder
Copy link
Member

Sure, no problem!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
Status: In Progress
Development

No branches or pull requests

2 participants