Skip to content

Book 3.10.2: Sampling Directions towards a Hittable - Updates to Hittable List Missing #1267

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
hollasch opened this issue Sep 13, 2023 Discussed in #1256 · 1 comment
Closed
Assignees
Milestone

Comments

@hollasch
Copy link
Collaborator

Discussed in #1256

Originally posted by davidfrogley September 7, 2023
Code listings in chapter 10.2 do not include changes to the hittable_list class, which should include an override of the pdf_value and generate methods from the hittable base class. Without these, the rendered image uses the default value for both of these (0 for pdf_value, and vec3(1,0.0) for generate). This results in a completely black image, except for the light on the ceiling.

@hollasch hollasch added this to the v4.0.0 milestone Sep 13, 2023
@hollasch hollasch changed the title Book 3, Chapter 10.2 Sampling Directions towards a Hittable - Updates to Hittable List Missing Book 3.10.2: Sampling Directions towards a Hittable - Updates to Hittable List Missing Apr 19, 2024
@hollasch hollasch self-assigned this Apr 25, 2024
@hollasch
Copy link
Collaborator Author

Now covered in #1318.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

1 participant