Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Rewrite book 1 diffuse in more straightforward way #992

Closed
trevordblack opened this issue Feb 10, 2022 · 0 comments
Closed

Rewrite book 1 diffuse in more straightforward way #992

trevordblack opened this issue Feb 10, 2022 · 0 comments
Assignees
Milestone

Comments

@trevordblack
Copy link
Collaborator

...

In think that when implementing recursive bouncing for the first time, sampling a direction uniformly is one of the first things to try.

This is actually how I would rewrite the chapter. Start with the "naive" approach, and then correct toward cosine law. We start on cos^2 today (I literally cannot remember if it's cos^3 or cos^2) because that was the outcome of the algorithm in the initial version of the book, and so we say upfront that that way of doing it was wrong. With enough time past since the initial publication of v1, it might be worth rearranging them.

Originally posted by @trevordblack in #924 (comment)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant