This repository has been archived by the owner on Oct 26, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 250
feat(Sync for Reddit): Add Fix video downloads
patch
#710
Merged
oSumAtrIX
merged 2 commits into
ReVanced:dev
from
1fexd:fix/sync-reddit-video-downloader
Oct 17, 2024
Merged
feat(Sync for Reddit): Add Fix video downloads
patch
#710
oSumAtrIX
merged 2 commits into
ReVanced:dev
from
1fexd:fix/sync-reddit-video-downloader
Oct 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oSumAtrIX
changed the title
fix(sync): Reddit video downloader
feat(Sync for Reddit): Add Oct 4, 2024
Fix video downloads
patch
oSumAtrIX
reviewed
Oct 4, 2024
app/src/main/java/app/revanced/integrations/syncforreddit/internal/RedditVideoPlaylistParser.kt
Outdated
Show resolved
Hide resolved
oSumAtrIX
reviewed
Oct 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is a reimplementation of the parser needed? Can the existing parser in Sync not be fixed for that?
Just rewriting it as an integrations patch was less tedious and allowed me to easily test it standalone |
oSumAtrIX
approved these changes
Oct 17, 2024
Thank you for contributing to ReVanced. Join us on Discord to receive a role for your contribution. |
github-actions bot
pushed a commit
that referenced
this pull request
Oct 17, 2024
# [1.16.0-dev.8](v1.16.0-dev.7...v1.16.0-dev.8) (2024-10-17) ### Features * **Sync for Reddit:** Add `Fix video downloads` patch ([#710](#710)) ([888de49](888de49))
github-actions bot
pushed a commit
that referenced
this pull request
Oct 20, 2024
# [1.16.0](v1.15.0...v1.16.0) (2024-10-20) ### Bug Fixes * **YouTube - Hide layout components:** Adjust settings text ([#713](#713)) ([119c416](119c416)) * **YouTube - Hide layout components:** Hide new type of Playable ([1a58a40](1a58a40)) * **YouTube - Spoof video streams:** Fix playback for Android VR by removing invalid body as well ([#716](#716)) ([8ad3f78](8ad3f78)) * **YouTube - Spoof video streams:** Handle app left open for a long time ([#709](#709)) ([ea4b073](ea4b073)) ### Features * **Sync for Reddit:** Add `Fix video downloads` patch ([#710](#710)) ([888de49](888de49)) * **Twitter:** Add `Change link sharing domain` patch ([#715](#715)) ([c673951](c673951)) * **YouTube - Hide layout components:** Add option to hide Yoodles (YouTube Doodles) ([#712](#712)) ([4b5f3de](4b5f3de)) * **YouTube - Hide Shorts components:** Add option to hide like fountain ([#708](#708)) ([16c3ef7](16c3ef7)) * **YouTube - Hide Shorts components:** Add options to hide `Use template`, `Upcoming`, `Green screen` buttons ([#714](#714)) ([faad754](faad754)) * **YouTube - Hide Shorts components:** Hide `Hashtag` button ([#717](#717)) ([1c9a966](1c9a966)) * **YouTube:** Support versions `19.25` and `19.34` ([#689](#689)) ([61569ba](61569ba))
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-implements MPD manifest interpretation to fix video track not being saved - see ReVanced/revanced-patches#3739