Skip to content

Fix missing nullability on Single.subscribe(BiConsumer) #7331

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Sep 6, 2021

Conversation

ZacSweers
Copy link
Contributor

Resolves #7330

@codecov
Copy link

codecov bot commented Sep 6, 2021

Codecov Report

Merging #7331 (1e42ea2) into 3.x (b476914) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x    #7331      +/-   ##
============================================
- Coverage     99.55%   99.50%   -0.05%     
+ Complexity     6781     6780       -1     
============================================
  Files           751      751              
  Lines         47482    47482              
  Branches       6378     6378              
============================================
- Hits          47271    47249      -22     
- Misses           96      108      +12     
- Partials        115      125      +10     
Impacted Files Coverage Δ
...rc/main/java/io/reactivex/rxjava3/core/Single.java 100.00% <ø> (ø)
...tivex/rxjava3/internal/jdk8/ParallelCollector.java 89.90% <0.00%> (-8.26%) ⬇️
.../operators/flowable/FlowableBlockingSubscribe.java 93.02% <0.00%> (-4.66%) ⬇️
...rnal/operators/flowable/FlowableFlatMapSingle.java 93.60% <0.00%> (-4.07%) ⬇️
...vex/rxjava3/internal/operators/maybe/MaybeAmb.java 96.96% <0.00%> (-3.04%) ⬇️
...java3/internal/schedulers/TrampolineScheduler.java 97.40% <0.00%> (-2.60%) ⬇️
...eactivex/rxjava3/processors/BehaviorProcessor.java 97.48% <0.00%> (-2.52%) ⬇️
.../operators/observable/ObservableFlatMapSingle.java 94.44% <0.00%> (-2.39%) ⬇️
...o/reactivex/rxjava3/processors/AsyncProcessor.java 97.91% <0.00%> (-2.09%) ⬇️
...internal/operators/flowable/FlowableSwitchMap.java 98.58% <0.00%> (-1.42%) ⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b476914...1e42ea2. Read the comment docs.

@akarnokd akarnokd merged commit ce45fc2 into ReactiveX:3.x Sep 6, 2021
@akarnokd akarnokd added this to the 3.1-support milestone Sep 6, 2021
@ZacSweers ZacSweers deleted the z/nullabilityFix branch September 6, 2021 14:10
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confusing nullability on subscribe(BiConsumer)
2 participants