Merge pull request #211 from WyriHaximus-secret-labs/promise-should-support-low-level-throwable

Promise should support low level Throwable

Author: asm89

src/React/Promise.php

@@ -85,7 +85,7 @@ function ($value) use ($subject) {
                 $subject->onCompleted();
             },
             function ($error) use ($subject) {
-                $error = $error instanceof \Exception ? $error : new RejectedPromiseException($error);
+                $error = $error instanceof \Throwable ? $error : new RejectedPromiseException($error);
                 $subject->onError($error);
             }
         );

test/Rx/Functional/React/PromiseToObservableTest.php

@@ -3,8 +3,8 @@
 
 namespace Rx\Functional\React;
 
-use Exception;
 use React\Promise\Deferred;
+use React\Promise\Promise as ReactPromise;
 use Rx\Functional\FunctionalTestCase;
 use Rx\Observer\CallbackObserver;
 use Rx\React\Promise;
@@ -40,7 +40,9 @@ function () {
      */
     public function from_promise_failure()
     {
-        $p = Promise::rejected(new Exception('error'));
+        $p = new ReactPromise(function () {
+            1 / 0;
+        });
 
         $source = Promise::toObservable($p);
 
@@ -49,8 +51,8 @@ function ($x) {
               $this->assertFalse(true);
 
           },
-          function ($error) {
-              $this->assertEquals($error, new Exception('error'));
+          function (\Throwable $error) {
+              $this->assertStringContainsStringIgnoringCase('division by zero', $error->getMessage());
           },
           function () {
               $this->assertFalse(true);