Skip to content

Commit ecfed5e

Browse files
authoredSep 10, 2022
PHP 8.2 compatibility (#215)
* Test on PHP 8.2 * Turn off fail fast so we can see all errors * Declare disposable property on scheduled item This fixes the following error on 8.2: ``` Deprecated: Creation of dynamic property Rx\Scheduler\ScheduledItem::$disposable is deprecate ```
1 parent 6e769ab commit ecfed5e

File tree

2 files changed

+3
-0
lines changed

2 files changed

+3
-0
lines changed
 

‎.github/workflows/ci.yml

+2
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,13 @@ jobs:
99
name: PHPUnit (PHP ${{ matrix.php }} on ${{ matrix.os }})
1010
runs-on: ${{ matrix.os }}
1111
strategy:
12+
fail-fast: false
1213
matrix:
1314
os:
1415
- ubuntu-20.04
1516
- windows-2019
1617
php:
18+
- 8.2
1719
- 8.1
1820
- 8.0
1921
- 7.4

‎src/Scheduler/ScheduledItem.php

+1
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ class ScheduledItem
1313
private $action;
1414
private $dueTime;
1515
private $comparer;
16+
private $disposable;
1617

1718
public function __construct($scheduler, $state, $action, $dueTime, $comparer = null)
1819
{

0 commit comments

Comments
 (0)