Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix Unfold, Axiom, and Def in the presence of shadowing #2

Open
favonia opened this issue May 9, 2022 · 0 comments
Open

Fix Unfold, Axiom, and Def in the presence of shadowing #2

favonia opened this issue May 9, 2022 · 0 comments

Comments

@favonia
Copy link
Contributor

favonia commented May 9, 2022

This is a note that the current conversion checker is incorrect in the presence of shadowing, because the constructs Domain.Unfold, Domain.Axiom, Syntax.Axiom, Syntax.Def only remember the top-level names provided by the user. The checker could potentially mistake heads with the same top-level names as judgmentally equal, depending on whether unfolding is forced. A correct implementation should instead use a more globally unique identifier, such as a pair of a file path and its index in that unit (e.g., "/cool/lib.ag", 10). I would like to address this issue only after rewriting the bantorra library (a library for unit path resolution).

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant