Rectification Campaign II: Restrictions, etc. #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonsterling
changed the title
|
Roadmap:
|
…non-restriction type" This reverts commit f4df7db.
jonsterling
force-pushed
the
rectification
branch
from
4de2302 to
fcc741e
Compare
jonsterling
commented
Aug 14, 2018
| (* This is not backwards, FYI. *) | ||
| List.rev @@ | ||
| (* ~~This is not backwards, FYI.~~ *) | ||
| (* NARRATOR VOICE: it was backwards. *) |
There was a problem hiding this comment.
I should be forbidden to use List.rev... I get so owned by it.
This comment has been minimized.
This comment has been minimized.
Closed
jonsterling
force-pushed
the
rectification
branch
from
b155909 to
3d24751
Compare
Closed
|
This should work: |
|
I think I will actually merge this now that it is cleaned up; the PR is getting too big. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing box modality, because the cure was worse than the disease. We should wait until we can implement time warps 😉
Preliminary work toward Find a way to limit the pain of restriction pretypes (or remove them) #231
resolves bug in path type coercion? #228
resolves composition in path types #222
resolves variables getting reversed in HITs #234 (?)
resolves Add neutral coe #212
resolves coercing in Code-like type...? #237
resolves "Tried to evaluate non-dimension term ... as dimension" #240
resolves Find a way to implement strict composition #238
very basic
autotactic (will become better as I refactor the refiner)disabling strict composition for now, because what we had was wrong, and I am not yet decided on how to make it right
Huge thanks to @ecavallo for exercising all the bugs fixed in this PR.