Skip to content

Commit b8316d5

Browse files
committed
Fix for git lfs failure in multi-arch build
1 parent 13653e7 commit b8316d5

File tree

4 files changed

+9
-2
lines changed

4 files changed

+9
-2
lines changed

.circleci/config.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,11 @@ jobs:
7979
image: ubuntu-1604:201903-01
8080
steps:
8181
- checkout
82+
- run:
83+
name: Checkout LFS
84+
commnad: |
85+
git lfs install
86+
git lfs pull
8287
- run:
8388
name: Setup Docker client experimental features
8489
command: |

Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ ARG PACK=0
3434
ARG TEST=0
3535

3636
RUN if [ "$PACK" = "1" ]; then make -C opt pack; fi
37-
RUN if [ "$TEST" = "1" ]; then make -C opt test $BUILD_ARGS; fi
37+
RUN if [ "$TEST" = "1" ]; then make -C opt test $BUILD_ARGS NO_LFS=1; fi
3838

3939
#----------------------------------------------------------------------------------------------
4040
# FROM redis:latest

Dockerfile.arm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ ARG PACK=0
3434
ARG TEST=0
3535

3636
RUN if [ "$PACK" = "1" ]; then make -C opt pack; fi
37-
RUN if [ "$TEST" = "1" ]; then make -C opt test $BUILD_ARGS; fi
37+
RUN if [ "$TEST" = "1" ]; then make -C opt test $BUILD_ARGS NO_LFS=1; fi
3838

3939
RUN [ "cross-build-end" ]
4040

opt/Makefile

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -124,8 +124,10 @@ endif
124124
TEST_REPORT_DIR ?= $(PWD)
125125

126126
test:
127+
ifneq ($(NO_LFS),1)
127128
$(SHOW)if [ "$(git lfs env > /dev/null 2>&1 ; echo $?)" != "0" ]; then cd $(ROOT); git lfs install; fi
128129
$(SHOW)cd $(ROOT); git lfs pull
130+
endif
129131
$(SHOW)set -e ;\
130132
cd $(ROOT)/test ;\
131133
python3 -m RLTest $(TEST_ARGS) --test basic_tests.py --module $(INSTALL_DIR)/redisai.so ;\

0 commit comments

Comments
 (0)