Skip to content

Commit e7649d1

Browse files
committed
Fix memleaks from Valgrind runs [WIP]
1 parent 3d2fff3 commit e7649d1

File tree

3 files changed

+7
-2
lines changed

3 files changed

+7
-2
lines changed

src/backends/tensorflow.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -314,7 +314,6 @@ RAI_Model *RAI_ModelCreateTF(RAI_Backend backend, const char* devicestr,
314314
ret->outputs = outputs_;
315315
ret->refCount = 1;
316316

317-
318317
return ret;
319318
}
320319

@@ -338,6 +337,8 @@ void RAI_ModelFreeTF(RAI_Model* model, RAI_Error* error) {
338337
TF_DeleteGraph(model->model);
339338
model->model = NULL;
340339

340+
RedisModule_Free(model->devicestr);
341+
341342
if (model->inputs) {
342343
size_t ninputs = array_len(model->inputs);
343344
for (size_t i=0; i<ninputs; i++) {

src/backends/torch.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -154,14 +154,14 @@ RAI_Script *RAI_ScriptCreateTorch(const char* devicestr, const char *scriptdef,
154154
ret->devicestr = RedisModule_Strdup(devicestr);
155155
ret->refCount = 1;
156156

157-
158157
return ret;
159158
}
160159

161160
void RAI_ScriptFreeTorch(RAI_Script* script, RAI_Error* error) {
162161

163162
torchDeallocContext(script->script);
164163
RedisModule_Free(script->scriptdef);
164+
RedisModule_Free(script->devicestr);
165165
RedisModule_Free(script);
166166
}
167167

src/redisai.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -817,6 +817,10 @@ void RedisAI_ReplicateTensorSet(RedisModuleCtx *ctx, RedisModuleString *key, RAI
817817
RedisModule_Replicate(ctx, "AI.TENSORSET", "scvcb", key, dtypestr,
818818
dims, ndims, "BLOB", data, size);
819819

820+
// for (long long i=0; i<ndims; i++) {
821+
// RedisModule_Free(dims[i]);
822+
// }
823+
820824
RedisModule_Free(dtypestr);
821825
}
822826

0 commit comments

Comments
 (0)