Skip to content

RedisAI crashes on MODELRUN if INPUTS/OUTPUTS names are not present in the TF graph #127

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
hhsecond opened this issue May 23, 2019 · 2 comments
Closed

RedisAI crashes on MODELRUN if INPUTS/OUTPUTS names are not present in the TF graph #127

hhsecond opened this issue May 23, 2019 · 2 comments
Labels
bug

Comments

@hhsecond
Copy link

hhsecond commented May 23, 2019 •
edited
Loading

If by mistake user sets the model with the wrong name in the INPUTS / OUTPUTS list, RedisAI crashes on MODELRUN without proper error message.

client.modelset(
    'model', rai.Backend.tf, rai.Device.cpu, model, input=['WrongName'], output=['WrongName'])

From a UX standpoint, we should be raising an error while setting the model about the wrong data, IMO
@lantiga lantiga added the bug label May 23, 2019
@lantiga
Copy link
Contributor

lantiga commented May 23, 2019

We test for omission but not for this, I'll fix right away

@lantiga lantiga mentioned this issue May 23, 2019
Merged
@lantiga
Copy link
Contributor

lantiga commented May 23, 2019

Solved by #128

@lantiga lantiga closed this as completed May 23, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lantiga @hhsecond