Skip to content

Returned wrong attribute on Builder pattern | prototype example #14

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Open
vlaksi opened this issue Mar 25, 2023 · 1 comment
Open

Returned wrong attribute on Builder pattern | prototype example #14

vlaksi opened this issue Mar 25, 2023 · 1 comment

Comments

@vlaksi
Copy link

vlaksi commented Mar 25, 2023 •
edited
Loading

This is not only related to the typescript code samples, it is more related to the book, but I can not find where to submit that kind of issue.

Issue

Once we make attribute: result we should return this.result not this.manual . I know this is only a prototype, but still, I guess this should be applied.

image

Best,
Vladislav.
@vlaksi vlaksi changed the title Typo on prototype code for Builder pattern Returned wrong attribute on Builder pattern prototype example Mar 25, 2023
@vlaksi vlaksi changed the title Returned wrong attribute on Builder pattern prototype example Returned wrong attribute on Builder pattern | prototype example Mar 25, 2023
@vlaksi
Copy link
Author

vlaksi commented Mar 26, 2023

The manual is only a type of this.result.

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vlaksi