Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Licence is incorrectly rejected #1

Open
bronger opened this issue Jan 14, 2023 · 2 comments
Open

Licence is incorrectly rejected #1

bronger opened this issue Jan 14, 2023 · 2 comments

Comments

@bronger
Copy link

bronger commented Jan 14, 2023

I have trouble validating my crate due to the second term at

if utils.is_url(license[0]) and utils.get_norm_value(entity, "@id")[0] != "./" and utils.get_norm_value(entity, "@id")[0] != "ro-crate-metadata.json":
It excludes the root data entity but shouldn’t only ro-crate-metadata.json be excluded?

@a-mile
Copy link

a-mile commented Jul 11, 2023

@bronger I think that is correct. I'm attaching a valid URL license to the root data entity and always getting an IDError result from upd_licenseRlt. I would like to understand why that second part of the if statement is necessary.

@wragge
Copy link

wragge commented Aug 23, 2023

I'm not clear on why you can't have a license on ro-crate-metadata.json either. I'm following the pattern here to attach a separate CC0 license for the metadata itself: https://www.researchobject.org/ro-crate/1.1/contextual-entities.html#metadata-license

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants