Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

bs4Dash::bs4Alert #255

Open
yogat3ch opened this issue Dec 23, 2021 · 7 comments · May be fixed by #271
Open

bs4Dash::bs4Alert #255

yogat3ch opened this issue Dec 23, 2021 · 7 comments · May be fixed by #271
Labels

Comments

@yogat3ch
Copy link
Contributor

Hi RinteRface devs,
I noticed that bs4Alert is listed in the docs but seems to have gotten deleted from the package itself?

Searching the code base for bs4Alert only yields an entry in NEWS.md

@DivadNojnarg
Copy link
Member

Thanks for the report. Let me check what is wrong.

@yogat3ch
Copy link
Contributor Author

Thanks for checking into this @DavidNojnarg. I ended up re-making it. I don't know if that's helpful but thought I'd add it here

@yogat3ch
Copy link
Contributor Author

yogat3ch commented Feb 2, 2022

Should I PR my version above with some docs? @DivadNojnarg

@DivadNojnarg
Copy link
Member

Hi. Your link points me to a 404 error. I did not manage to find it in the currét version. Which bs4Dash version arz you using?

@yogat3ch
Copy link
Contributor Author

yogat3ch commented Feb 3, 2022

That's bizarre. It's a public repo. This is what I see when I follow the link:
image
The latest dev version, albeit slightly modified.
match_letters can be replaced with match.arg

@yogat3ch yogat3ch linked a pull request Mar 18, 2022 that will close this issue
@DivadNojnarg
Copy link
Member

bs4Alert was removed from the last version and I don't plan to re-include it. Now there are createAlert and closeAlert which are just more flexible.

@yogat3ch
Copy link
Contributor Author

yogat3ch commented Apr 23, 2022

@DivadNojnarg What if folks aren't looking for a pop-up and just want a static alert to show somewhere, as in my case?
Why remove functionality that isn't effectively superseded when it doesn't add dependencies?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants