Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Error in usage example for gctf.centralized_gradients_for_optimizer #13

Closed
Rishit-dagli opened this issue Mar 3, 2021 · 0 comments · Fixed by #17
Closed

Error in usage example for gctf.centralized_gradients_for_optimizer #13

Rishit-dagli opened this issue Mar 3, 2021 · 0 comments · Fixed by #17
Assignees
@Rishit-dagli
Labels
documentation Improvements or additions to documentation
Milestone
Release v0.0.3

Comments

@Rishit-dagli
Copy link
Owner

I noticed that the docstrings for gctf.centralized_gradients_for_optimizer have an error in the example usage section. The example creates an Adam optimizer instance and saves it to opt however the centralized_gradients_for_optimizer is applied on optimizer which ideally does not exist and running the example would result in an error.
@Rishit-dagli Rishit-dagli added the documentation Improvements or additions to documentation label Mar 3, 2021
@Rishit-dagli Rishit-dagli self-assigned this Mar 3, 2021
@Rishit-dagli Rishit-dagli added this to the Release v0.0.3 milestone Mar 3, 2021
@Rishit-dagli Rishit-dagli mentioned this issue Mar 7, 2021
Merged
@Rishit-dagli Rishit-dagli mentioned this issue Mar 11, 2021
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@Rishit-dagli Rishit-dagli

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
Release v0.0.3
1 participant
@Rishit-dagli