Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Can't compile 2.0.2 due to failed assertion with 4.1.1 croaring-sys crate release #148

Closed
mgattozzi opened this issue Aug 5, 2024 · 2 comments

Comments

@mgattozzi
Copy link

mgattozzi commented Aug 5, 2024

This line here uses 4.0 as the version of croaring for version 2.0.2

However, the sys crate in the same commit for that tag uses 4.1.

I noticed this when I updated my dep tree and it broke my build through a transient dependency of this.

@mgattozzi
Copy link
Author

Hmm from further investigation I think it's the update to 4.1.1 as this code compiles fine

https://github.com/influxdata/influxdb/blob/2b8fc7b44e767ad52ea596378121ac5cec749af3/Cargo.lock#L1057-L1073

but updating to 4.1.1 causes a complete failure. This is definitely a breaking change.

@mgattozzi mgattozzi changed the title Can't compile 2.0.2 due to failed assertion Can't compile 2.0.2 due to failed assertion with 4.1.1 croaring-sys crate release Aug 5, 2024
@Dr-Emann Dr-Emann mentioned this issue Aug 5, 2024
@mgattozzi
Copy link
Author

Thanks for the quick turn around @Dr-Emann 😄

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant