Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

build fails on 2.0.3 #156

Closed
tzachar opened this issue Sep 19, 2024 · 2 comments
Closed

build fails on 2.0.3 #156

tzachar opened this issue Sep 19, 2024 · 2 comments

Comments

@tzachar
Copy link

tzachar commented Sep 19, 2024

the following line fails on rust 1.81:

build.flag_if_supported(format!("-march={target_arch}"));

there should be a '&' before the format!:

build.flag_if_supported(&format!("-march={target_arch}"));
@Dr-Emann
Copy link
Member

The problem is that build.flag_if_supported was changed to support owned and borrowed strings in cc version 1.1, but coraring-sys incorrectly claimed it only needed at least cc version 1.0. You should be able to cargo update your cc version to something > 1.1, or the newest croaring-sys (published today) now correctly identifies the minimal cc version it requires.

See #149, which updated the minimal cc version, but today is the first croaring-sys publish since that change.

@tzachar
Copy link
Author

tzachar commented Sep 22, 2024

10x.
Did a cargo update, which solved the issue.

@tzachar tzachar closed this as completed Sep 22, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants