Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Removing Generator in iterable|Generator is not break BC #752

Open
vjik opened this issue Nov 12, 2023 · 1 comment
Open

Removing Generator in iterable|Generator is not break BC #752

vjik opened this issue Nov 12, 2023 · 1 comment

Comments

@vjik
Copy link

vjik commented Nov 12, 2023

iterable included Generator, so removing Generator doesn't change anything and don't break BC.

Example: https://3v4l.org/SENSO

But current result:

[BC] CHANGED: The parameter $rows of Yiisoft\Db\QueryBuilder\AbstractQueryBuilder#batchInsert() changed from iterable|Generator to a non-contravariant iterable
[BC] CHANGED: The parameter $rows of Yiisoft\Db\QueryBuilder\AbstractQueryBuilder#batchInsert() changed from iterable|Generator to iterable
@Ocramius
Copy link
Member

Probably needs a test addition here: https://github.com/Roave/BackwardCompatibilityCheck/tree/2ffdcbbd51b677c3d615caabbdafbdbc04e940f7/test/unit/DetectChanges/Variance

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Ocramius @vjik