This repository has been archived by the owner on Feb 19, 2025. It is now read-only.
Add sign data provider #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jefersson Nathan <admin@phpse.net>
Signed-off-by: Jefersson Nathan <admin@phpse.net>
Signed-off-by: Jefersson Nathan <admin@phpse.net>
Signed-off-by: Jefersson Nathan <admin@phpse.net>
Signed-off-by: Jefersson Nathan <admin@phpse.net>
Signed-off-by: Jefersson Nathan <admin@phpse.net>
asgrim
suggested changes
Apr 18, 2018
| @@ -13,13 +13,23 @@ | |||
| */ | |||
| final class FileContentSignerTest extends TestCase | |||
| { | |||
| public function testSign() | |||
| public function signProvider() | |||
There was a problem hiding this comment.
Please add return type : array and ideally a phpdoc block with @return string[][]
| /** | ||
| * @dataProvider signProvider | ||
| */ | ||
| public function testSign($expected, $inputString) |
There was a problem hiding this comment.
Please add parameter types string for each and return type void
asgrim
approved these changes
Apr 18, 2018
|
Rebased, fixed up and merged manually (so PR won't close automatically) in 2341f4f - thanks @peter279k for the change! 👍 |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed log
signProviderfor thetestSigndata provider.