Skip to content
This repository has been archived by the owner on Feb 19, 2025. It is now read-only.

SHA encoder #9

Merged
merged 3 commits into from
Jan 27, 2017
Merged

SHA encoder #9

merged 3 commits into from
Jan 27, 2017

Conversation

asgrim
Copy link
Member

@asgrim asgrim commented Jan 27, 2017

Fixes #8

@asgrim asgrim requested review from Ocramius and malukenho January 27, 2017 17:31
@asgrim asgrim changed the title Sha encoder SHA encoder Jan 27, 2017
@malukenho
Copy link
Collaborator

Seems good to me @asgrim 👍

Ocramius
Ocramius suggested changes Jan 27, 2017
View reviewed changes
src/Encoder/ShaSumEncoder.php

namespace Roave\Signature\Encoder;

final class ShaSumEncoder implements EncoderInterface
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sha1

@Ocramius Ocramius merged commit bf21a3f into master Jan 27, 2017
@Ocramius Ocramius deleted the sha-encoder branch January 27, 2017 19:42
@Ocramius
Copy link
Member

👍

@Ocramius Ocramius added this to the 1.0.0 milestone Jan 27, 2017
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@Ocramius Ocramius Ocramius approved these changes

@malukenho malukenho Awaiting requested review from malukenho

Assignees

@Ocramius Ocramius

@malukenho malukenho

Labels
enhancement
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@asgrim @malukenho @Ocramius