Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[feat] Allow .local access #19

Open
Reckless-Satoshi opened this issue Nov 5, 2023 · 8 comments
Open

[feat] Allow .local access #19

Reckless-Satoshi opened this issue Nov 5, 2023 · 8 comments

Comments

@Reckless-Satoshi
Copy link

The primary use case of hosting the RoboSats client at the moment is to use any browser locally while enjoying the benefit of the torification. By only allowing .onion users of the StartOS app still need Tor Browser plus their requests take double the time (Tor circuit to their node + tor circuit to the coordinator(s).

In preliminary tests @kn0wmad found that the chat was not working when using .local it was no further investigated. I see no clear issue why the chat would not work, so I think this should be an easy fix if the issue can be replicated.

@gStart9
Copy link
Contributor

gStart9 commented May 16, 2024

I've taken on the robosats-startos package for Start9 and will look into this.

@gStart9
Copy link
Contributor

gStart9 commented Sep 30, 2024

Hi there, with the 070-client release (+ patch (Thanks @KoalaSat)) things seem to be working, and even most things are working on the .local, EXCEPT when a trade has been initiated and the messaging needs to happen, then we're seeing this (only on .local, .onion works perfectly):

Uncaught (in promise) DOMException: The operation is insecure.
    _connect https://ourreallylong.local/static/frontend/main.js:205
    promise callback*14262/e.prototype._connect https://ourreallylong.local/static/frontend/main.js:205
    e https://ourreallylong.local/static/frontend/main.js:205
    e https://ourreallylong.local/static/frontend/main.js:205
    e https://ourreallylong.local/static/frontend/main.js:205
    e https://ourreallylong.local/static/frontend/main.js:205
    f https://ourreallylong.local/static/frontend/main.js:205
    M https://ourreallylong.local/static/frontend/main.js:205
    Z https://ourreallylong.local/static/frontend/main.js:205
    r https://ourreallylong.local/static/frontend/main.js:205
    s https://ourreallylong.local/static/frontend/main.js:205
    o https://ourreallylong.local/static/frontend/main.js:205
    o https://ourreallylong.local/static/frontend/main.js:205
    e https://ourreallylong.local/static/frontend/main.js:205
    Ke https://ourreallylong.local/static/frontend/main.js:205
    P https://ourreallylong.local/static/frontend/main.js:205
    tl https://ourreallylong.local/static/frontend/main.js:205
    wc https://ourreallylong.local/static/frontend/main.js:205
    ac https://ourreallylong.local/static/frontend/main.js:205
    Ho https://ourreallylong.local/static/frontend/main.js:205
    bc https://ourreallylong.local/static/frontend/main.js:205
    bc https://ourreallylong.local/static/frontend/main.js:205
    nc https://ourreallylong.local/static/frontend/main.js:205
    E https://ourreallylong.local/static/frontend/main.js:205
    z https://ourreallylong.local/static/frontend/main.js:205
main.js:205

I opened the file but I don't even see many newline chars. Any ideas? Thanks!

@KoalaSat
Copy link
Member

KoalaSat commented Oct 2, 2024

@gStart9 can you confirm this was not happening in previous versions? Are you using firefox based browser?

@gStart9
Copy link
Contributor

gStart9 commented Oct 3, 2024

Yes looks like that's initially why we turned off .local access:

Here was the issue (on the frontend at least, no console log from then) in 0.5.3:
image

@KoalaSat
Copy link
Member

KoalaSat commented Oct 3, 2024

I seems related to a limitation on the description library we use for chat messages. I'll need to take a look but I'm not sure if I can fix it.

@KoalaSat
Copy link
Member

KoalaSat commented Oct 3, 2024

Some extra info: openpgpjs/openpgpjs#320

@gStart9
Copy link
Contributor

gStart9 commented Oct 3, 2024

Just FYI with .local, our users trust their server's CA system wide and instruct Firefox specifically to trust system-trusted certs:

So in theory it should know it's in a secure context.

@KoalaSat
Copy link
Member

KoalaSat commented Oct 7, 2024

For the record: I tested to redirect my hosts file to http://test.local and visiting on my machine the chat works. It doesn´t seem to be related to the address. I'll try to make https work

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants