Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Correct CDN to use #614

Closed
torydebra opened this issue May 15, 2023 · 3 comments · Fixed by #615
Closed

Correct CDN to use #614

torydebra opened this issue May 15, 2023 · 3 comments · Fixed by #615
Labels

Comments

@torydebra
Copy link

Description

  • Library Version: last
  • ROS Version: noetic
  • Platform / OS: ubuntu 20

Steps To Reproduce
The CDN indicated in the ROS tutorials seems to not work anymore :

<script src="http://static.robotwebtools.org/EventEmitter2/current/eventemitter2.js"></script>
<script src="http://static.robotwebtools.org/roslibjs/current/roslib.js"></script>

Is the new correct CDN to be used the one indicated in the readme? What about the eventemitter2.js file?

https://cdn.jsdelivr.net/npm/roslib@1/build/roslib.min.js

Thanks!

@torydebra torydebra added the bug label May 15, 2023
@MatthijsBurgh
Copy link
Contributor

Forget about the ROS wiki, that one is really out-of-date.

The README is correct.

For eventemitter2 use https://cdn.jsdelivr.net/npm/eventemitter2@6/lib/eventemitter2.min.js I will add this to the README.

@MatthijsBurgh
Copy link
Contributor

I think EventEmitter2 is included in the build and therefore no EventEmitter CDN is needed.

I will run the examples later to confirm this.

@MatthijsBurgh
Copy link
Contributor

Yes, I have tested the examples without EventEmitter CDN and these work.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants