Skip to content

Commit 6ce0eed

Browse files
author
Peter Soetens
committed
image_streamer: add virtual destructor such that subclass destructors can work
A classical C++ error, the delete was done on an ImageStreamer, which has a non-virtual destructor, leading to the subclasses destructor never being called, leading to memleaks. Signed-off-by: Peter Soetens <peter@thesourceworks.com>
1 parent bee4fa6 commit 6ce0eed

File tree

2 files changed

+6
-0
lines changed

2 files changed

+6
-0
lines changed

include/web_video_server/image_streamer.h

+2
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,8 @@ class ImageStreamer
1616
ImageStreamer(const async_web_server_cpp::HttpRequest &request, async_web_server_cpp::HttpConnectionPtr connection,
1717
image_transport::ImageTransport it);
1818

19+
virtual ~ImageStreamer();
20+
1921
void start();
2022

2123
bool isInactive();

src/image_streamer.cpp

+4
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,10 @@ ImageStreamer::ImageStreamer(const async_web_server_cpp::HttpRequest &request,
1414
invert_ = request.has_query_param("invert");
1515
}
1616

17+
ImageStreamer::~ImageStreamer()
18+
{
19+
}
20+
1721
void ImageStreamer::start()
1822
{
1923
image_sub_ = it_.subscribe(topic_, 1, &ImageStreamer::imageCallback, this);

0 commit comments

Comments
 (0)