Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Russian translation i18n is not applied (4.0.2 and above) #2960

Closed
2 of 5 tasks
rze0 opened this issue Oct 23, 2024 · 3 comments · Fixed by #2961
Closed
2 of 5 tasks

Russian translation i18n is not applied (4.0.2 and above) #2960

rze0 opened this issue Oct 23, 2024 · 3 comments · Fixed by #2961

Comments

@rze0
Copy link

rze0 commented Oct 23, 2024

Search before asking

  • I had searched in the issues and found no similar issues.

Operating System

  • macOS
  • Windows
  • Linux

Operating System Version

windows 10, windwos 11

It happens on the web browser too?

No, it just happens on the Desktop app

Rocket.Chat Desktop App Version

4.1.1

Rocket.Chat Server Version

6.12.0

Describe the bug

Russian translation i18n is not applied (4.0.2 and above)
I think it's related to #2856
If you change in Rocket.Chat.Electron\src\i18n\resources.ts 'ru' to 'ru-RU' then the translation is applied.

1
2
yarn start with modified resources.ts
3

How to Reproduce

  1. Install 4.1.1 ( 4.0.2 and above)
  2. switch system language to Russian or Russia-Russian (not sure what it looks like exactly)
  3. launch rocket chat desktop app
  4. see translation not applicable

Describe your Expected behavior

No response

Anything else

No response

Are you willing to submit a code contribution?

  • Yes, I am willing to submit a Pull Request!
@jeanfbrito
Copy link
Collaborator

@rze0 can you please test this new version and tell us if is fixed?

@rze0
Copy link
Author

rze0 commented Nov 14, 2024

@jeanfbrito Hi. I confirm, the translation works. Thank you!
Rocket Chat_2024-11-14_10-08-08

@jeanfbrito
Copy link
Collaborator

Thank you @rze0
Congratulations @rique223

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants