Test/add integration testing (#8)

Rossignol-h · web-flow · commit 0487eda4ff03 · 2022-11-06T01:05:21.000+01:00
* feat(board.html): add template for points display board * feat(server): add route for points display board * feat(board.html): complete template * test(test_points_board): start testing happy path * feat(board.html): add condition if no clubs in json * test(test_points_board): add sad path to test * test(units/): add test_unlimited_points.py * fix(server): add condition to limit purchase * fix(booking.html): add display of flash message * test(units/): test_unlimited_points.py passed * test(units/): change docstrings in test_unlimited_points.py * test(units/): done test_unlimited_points.py * fix(issue): [OpenClassrooms-Student-Center#2] * test(units/): add test_points_not_update.py with TDD approch added test and failed * fix(server): add substraction points after book places * test(units/): run test_points_not_update.py and passed * fix(issue): [OpenClassrooms-Student-Center#6] * test(units/): add test_book_under_12.py with TDD method: started with failed test * fix(server): add condition if book more 12 places * test(units/): complete test_book_under_12.py and run tests passed * fix(issue): [OpenClassrooms-Student-Center#4] * test(functional/): add & complete test_route.py * fix(404.html): add 404 handler and template * fix(500.html): add 500 handler and template * test(functional/): add & complete test_load_json.py * test(integration/): add & complete test of app * fix(server): issue book more than places available * test(integration/): cleanup test_app
diff --git a/server.py b/server.py
@@ -84,12 +84,13 @@ def book(competition,club):
         Competition's name and places available
         & the booking form
     """
-    foundClub = [c for c in clubs if c['name'] == club][0]
-    foundCompetition = [c for c in competitions if c['name'] == competition][0]
-    if foundClub and foundCompetition:
+    try:
+        foundClub = [c for c in clubs if c['name'] == club][0]
+        foundCompetition = [c for c in competitions if c['name'] == competition][0]
         return render_template('booking.html',club=foundClub,competition=foundCompetition)
-    else:
-        flash("Something went wrong-please try again")
+
+    except IndexError:
+        flash("Sorry, this club or competition wasn't found !!")
         return render_template('welcome.html', club=club, competitions=competitions, current_date=current_date)
 
 
@@ -115,6 +116,7 @@ def purchase_places():
     club_points = int(club['points'])
     placesRequired = int(request.form['places'])
     current_cart = cart[competition["name"]][club["name"]]
+    current_places_available = int(competition['numberOfPlaces'])
 
     if competition['date'] < current_date:
         flash("Sorry, this competition is over !")
@@ -133,6 +135,10 @@ def purchase_places():
         and now you have exceeded the limit of {MAX_PLACES} places !""")
         return render_template('booking.html', club=club, competition=competition, current_date=current_date), 400
 
+    elif placesRequired > current_places_available:
+        flash("Sorry, you book more places than available !")
+        return render_template('booking.html', club=club, competition=competition, current_date=current_date), 400
+
     else:
         competition['numberOfPlaces'] = int(competition['numberOfPlaces'])-placesRequired
 
diff --git a/templates/404.html b/templates/404.html
@@ -1,7 +1,7 @@
 <!DOCTYPE html>
 <html lang="en">
 <head>
-    <title>404</title>
+    <title>404 error page</title>
     <meta charset="utf-8">
     <meta name="viewport" content="width=device-width, initial-scale=1">
 </head>
diff --git a/tests/conftest.py b/tests/conftest.py
@@ -12,12 +12,6 @@ def client():
         yield client
 
 
-# @pytest.fixture
-# def current_date():
-#     now = datetime.datetime.now()
-#     return now.strftime("%Y-%m-%d, %H:%M:%S")
-
-
 @pytest.fixture
 def clubs_fixture():
     return [
@@ -75,8 +69,8 @@ def competitions_fixture():
         },
         {
             "name": "Champion Road",
-            "date": "2022-10-13 13:00:00",
-            "numberOfPlaces": "13"
+            "date": "2023-02-13 13:00:00",
+            "numberOfPlaces": "8"
         },
         {
             "name": "Ice Race",
@@ -103,26 +97,40 @@ def get(fixture, case , places=0):
     fixture[0].patch.object(server, 'competitions', fixture[2])
     fixture[0].patch.object(server, 'cart', fixture[3])
 
-    if case == "email":
+    valid_club = fixture[1][0]['name']
+    valid_competition = fixture[2][0]['name']
 
+    if case == "email":
         email = fixture[1][0]['email']
         data_email = {'email': email}
         return data_email
 
+    elif case == "wrong_email":
+        return {"email": "unknown_email@gmail.com"}
+
     elif case == "club_competition":
-        
-        club = fixture[1][0]['name']
-        competition = fixture[2][0]['name']
-        data_book = {'competition': competition, 'club': club}
+        data_book = {'competition': valid_competition, 'club': valid_club}
         return data_book
 
+    elif case == "club_unknown-competition":
+        return {'competition': "Black Race", 'club': valid_club}
+
     elif case == "club_competition_places":
-        
-        club = fixture[1][0]['name']
-        competition = fixture[2][0]['name']
-        data_purchase_places = {'competition': competition, 'club': club, 'places': places}
+        data_purchase_places = {'competition': valid_competition, 'club': valid_club, 'places': places}
         return data_purchase_places
 
-    elif case == "board":
+    elif case == "small_competition_places":
+        small_competition = fixture[2][2]['name']
+        data_purchase_places = {'competition': small_competition, 'club': valid_club, 'places': places}
+        return data_purchase_places
 
+    elif case == "past_competition_places":
+        past_competition = fixture[2][1]['name']
+        data_purchase_places = {'competition': past_competition, 'club': valid_club, 'places': places}
+        return data_purchase_places
+
+    elif case == "board":
         return  fixture[1]
+    
+    elif case == "empty_board":
+        return fixture[0].patch.object(server, 'clubs', '')
diff --git a/tests/integration/__init__.py b/tests/integration/__init__.py
diff --git a/tests/integration/test_app.py b/tests/integration/test_app.py
@@ -0,0 +1,45 @@
+from conftest import get
+
+
+"""
+    Testing a complete smooth scenario of a user :
+     * Home page
+     * Login
+     * book for a competition
+     * purchase places
+     * got to see display board
+     * Logout
+
+"""
+
+# ================================================== START TESTING
+
+
+def test_app(client, fixture):
+
+    assert client.get('/').status_code == 200
+    response = client.get('/')
+    assert b'Welcome to the GUDLFT Registration' in response.data
+
+    email = get(fixture, "email")
+    response = client.post('/showSummary', data=email)
+    assert response.status_code == 200
+
+    data = get(fixture, "club_competition")
+    response = client.get(f"/book/{data['competition']}/{data['club']}")
+    assert response.status_code == 200
+
+    data = get(fixture, "club_competition_places", 5)
+    response = client.post('/purchasePlaces', data=data)
+    assert response.status_code == 200
+
+    response = client.get('/board')
+    clubs = get(fixture, "board")
+    assert response.status_code == 200
+    for club in clubs:
+        assert club['name'] in response.data.decode()
+        assert str(club["points"]) in response.data.decode()
+
+    response = client.get('/logout')
+    assert response.status_code == 302
+    assert response.headers["Location"] == "/"
diff --git a/tests/integration/test_sad_app.py b/tests/integration/test_sad_app.py
@@ -0,0 +1,79 @@
+from conftest import get
+import pytest
+
+"""
+    Testing a complete worst scenario of a user :
+     * Home page : wrong endpoint (/home') doesn't exist.
+     * Login : with unknown email
+     * book for a unknown competition 
+     * purchase places :
+            * past competition
+            * more than 12 places,
+            * more than club's points,
+            * more than competition's places, (book 12 places, this competition has 8)
+
+     * got to see display board with empty data
+     * Logout successfully ;)
+
+    data used for this test :
+        Mostly :
+        club = Basic lift, 15 points
+        competition = Aka League, date [2023-02-05 10:00:00], 20 places. 
+
+"""
+
+# ================================================== START TESTING
+
+
+def test_sad_app(client, fixture):
+
+    response = client.get('/home')
+    assert response.status_code == 404
+    assert b'404 error page' in response.data
+
+    email = get(fixture, "wrong_email")
+    response = client.post('/showSummary', data=email)
+    assert response.status_code == 302
+    with pytest.raises(Exception) as exc_info:
+        assert str(exc_info.value) == "Sorry, this email wasn't found. Please try again with a correct email !!"
+
+
+    data = get(fixture, "club_unknown-competition")
+    response = client.get(f"/book/{data['competition']}/{data['club']}")
+    with pytest.raises(Exception) as exc_info:
+        assert str(exc_info.value) == "Sorry, this club or competition wasn&#39;t found !!"
+
+    data = get(fixture, "past_competition_places", 5)
+    response = client.post('/purchasePlaces', data=data)
+    assert response.status_code == 400
+    assert b'Sorry, this competition is over !' in response.data
+
+
+    data = get(fixture, "club_competition_places", 13)
+    response = client.post('/purchasePlaces', data=data)
+    assert response.status_code == 400
+    assert b'Sorry, you can&#39;t book more than 12 places !' in response.data
+
+
+    data = get(fixture, "small_competition_places", 12)
+    response = client.post('/purchasePlaces', data=data)
+    assert response.status_code == 400
+    assert b'Sorry, you book more places than available !' in response.data
+
+
+    data = get(fixture, "club_competition_places", 10)
+    response = client.post('/purchasePlaces', data=data)
+    data = get(fixture, "club_competition_places", 10)
+    response = client.post('/purchasePlaces', data=data)
+    assert response.status_code == 400
+    assert b'Sorry, your club doesn&#39;t have enough points !' in response.data
+
+
+    get(fixture, "empty_board")
+    response = client.get('/board')
+    assert b'Sorry, this section has no clubs to display' in response.data
+
+
+    response = client.get('/logout')
+    assert response.status_code == 302
+    assert response.headers["Location"] == "/"
