New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Make safer. #209

Merged

wmedrano merged 4 commits into main from safe

Sep 13, 2024

Member

wmedrano commented Sep 13, 2024

Marks shutdown as unsafe and links to details about posix signal handling. Closes Is NotificationHandler::shutdown() really safe? #106
Deactivating will leak the callback objects if there is a panic.

wmedrano added 4 commits

September 12, 2024 20:16


          Make shutdown unsafe.

2b4e565


          Don't return client,processor,notification if there was a panic.

39a3af9


          Add safety section.

50b170e


          Bump major version.

c0db4e7

wmedrano merged commit b25d6d4 into main

2 checks passed

wmedrano deleted the safe branch

September 13, 2024 14:32

# for free to join this conversation on GitHub. Already have an account? # to comment

Labels

None yet